[Test] fix test setup on ANet tests #15908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
force-pushed
the
anet_setup
branch
3 times, most recently
from
83dfbde
to
2a96b27
Compare
|
jenkins, test this please I'm not sure if the test fails are related: |
eileenmcnaughton
force-pushed
the
anet_setup
branch
from
2a96b27
to
ba382a0
Compare
|
@mlutfy yep - it was an e-notice - should be fixed now |
eileenmcnaughton
force-pushed
the
anet_setup
branch
from
ba382a0
to
79e99af
Compare
Per civicrm#15706 the setup for this test is creating invalid transactions. This fixes - I had to do an order fix in the process
eileenmcnaughton
force-pushed
the
anet_setup
branch
from
79e99af
to
0dea0c7
Compare
|
test this please |
|
@mlutfy this is passing now! |
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Test set up fix, including fixing Order.create to support being chained
Before
Test set up creates invalid Order & hence tests to ensure Order is correct fail
After
Test uses methods that create valid transactions. In order to support it I had to fix Order.create to support being chained
Technical Details
Per #15706 the setup for this test
is creating invalid transactions. This fixes - I had to do an order fix in the process
Comments
Issue exposed in #15706